linux-kernel - Re: [PATCH 5/6] x86: Remove useless unwinder backlink from irq regs saving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4E1187E4020000780004BF2C@nat28.tlf.novell.com>
Date:	Mon, 04 Jul 2011 08:29:08 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Frederic Weisbecker" <fweisbec@...il.com>
Cc:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Arnaldo Carvalho de Melo" <acme@...hat.com>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 5/6] x86: Remove useless unwinder backlink from irq
	 regs saving

>>> On 02.07.11 at 18:29, Frederic Weisbecker <fweisbec@...il.com> wrote:
> The unwinder backlink in interrupt entry is very useless.
> It's actually not part of the stack frame chain and thus is
> never used.

I very much doubt this - see dump_trace()'s comment in its IRQ-stack
related code portion (and the corresponding use of irq_stack_end[-1]).

Jan

> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Jan Beulich <JBeulich@...ell.com>
> ---
>  arch/x86/kernel/entry_64.S |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index 20dc8e6..6131432 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -327,7 +327,6 @@ ENDPROC(native_usergs_sysret64)
>  	jne 2f
>  	mov PER_CPU_VAR(irq_stack_ptr),%rsp
>  	EMPTY_FRAME 0
> -	pushq_cfi %rbp			/* backlink for unwinder */
>  	/*
>  	 * We entered an interrupt context - irqs are off:
>  	 */




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/