linux-kernel - Re: [PATCH 1/4] uml: cow_user.c warning corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWWPiFTwQ+0Et8eZZbCy-DtzRMeK=-rFY_NfEWWjYrZ2Q@mail.gmail.com>
Date:	Tue, 5 Jul 2011 13:38:05 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Richard Weinberger <richard@....at>
Cc:	Vitaliy Ivanov <vitalivanov@...il.com>,
	Jeff Dike <jdike@...toit.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	user-mode-linux-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] uml: cow_user.c warning corrections

On Tue, Jul 5, 2011 at 13:31, Richard Weinberger <richard@....at> wrote:
> Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov:
>> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger <richard@....at> wrote:
>> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
>> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
>> >> From: Vitaliy Ivanov <vitalivanov@...il.com>
>> >> Date: Tue, 5 Jul 2011 01:57:51 +0300
>> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
>> >> MIME-Version: 1.0
>> >> Content-Type: text/plain; charset=UTF-8
>> >> Content-Transfer-Encoding: 8bit
>> >>
>> >> arch/um/drivers/cow_user.c: In function ‘absolutize’:
>> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
>> >> ‘chdir’, declared with attribute warn_unused_result
>> >
>> > What compiler flags are you using?
>> > Using the default settings this warning does not show up.
>> > Most of the "ignoring return value" are totally useless.
>>
>> chdir is defined with warn_unused_result attribute and my gcc on
>> Ubuntu 11.04 issues warnings.
>> I don't use any additional flags on compiling UML.
>
> Ah, because of -D_FORTIFY_SOURCE=2, right?
> Then your patches makes sense.

I also saw it, with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5).
I never used FORTIFY_SOURCE.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/