linux-kernel - Re: [PATCH 02/11] GPIO: DA9052 GPIO module v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201107051643.45158.arnd@arndb.de>
Date:	Tue, 5 Jul 2011 16:43:44 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linaro-dev@...ts.linaro.org, ashish.jangam@...tcummins.com
Cc:	grant@...retlab.ca, Dajun <dajun.chen@...semi.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	jic23@....ac.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] GPIO: DA9052 GPIO module v2

On Tuesday 05 July 2011, ashishj3 wrote:
> DA9052 PMIC has 16 bit GPIO bus for peripheral control.
> 
> This patch add support for the GPIO pins on the DA9052.
> 
> Signed-off-by: David Dajun Chen <dchen@...semi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@...tcummins.com>
> CC: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
> Changes since v2
> - change of file name
> - correct reference to irq_base in function to_irq()
> - remove pdata dependency
> ---
>  drivers/gpio/Kconfig            |    6 +
>  drivers/gpio/Makefile           |    1 +
>  drivers/gpio/gpio-da9052.c      |  259 +++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/da9052/gpio.h |   47 +++++++
>  4 files changed, 313 insertions(+), 0 deletions(-)

I think I commented on this before, but please remove any header files
in include/linux that are not used as an interface between different
modules. If a header just describes properties of the hardware and is
used by a single source file, move the contents into that source file.

If a header is used by multiple files in one directory, make it a local
header in that directory.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/