linux-kernel - Re: [PATCH] mfd: Don't leak init_data in tps65910_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E13963F.1050905@slimlogic.co.uk>
Date:	Tue, 05 Jul 2011 23:54:55 +0100
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Jesper Juhl <jj@...osbits.net>
CC:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Subject: Re: [PATCH] mfd: Don't leak init_data in tps65910_i2c_probe

On 07/05/2011 11:29 PM, Jesper Juhl wrote:
> On Tue, 5 Jul 2011, Jesper Juhl wrote:
>
>> On Mon, 4 Jul 2011, Samuel Ortiz wrote:
>>
> [...]
>>> This is not a memory leak fix. And I actually prefer the == NULL check.
>>> Please remove the == NULL check replacement with !* and keep only the memory
>>> leak fixing part.
>>>
> Here's an updated patch.
>
>
> From: Jesper Juhl <jj@...osbits.net>
> Subject: [PATCH] mfd: Don't leak init_data in tps65910_i2c_probe
>
> There are a couple of situations where we leak init_data in
> drivers/mfd/tps65910.c:tps65910_i2c_probe() - this patch should take
> care of them.
>
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/mfd/tps65910.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 2229e66..7a3eb2d 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -151,8 +151,10 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>  	init_data->irq_base = pmic_plat_data->irq;
>  
>  	tps65910 = kzalloc(sizeof(struct tps65910), GFP_KERNEL);
> -	if (tps65910 == NULL)
> +	if (tps65910 == NULL) {
> +		kfree(init_data);
>  		return -ENOMEM;
> +	}
>  
>  	i2c_set_clientdata(i2c, tps65910);
>  	tps65910->dev = &i2c->dev;
> @@ -174,11 +176,13 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>  	if (ret < 0)
>  		goto err;
>  
> +	kfree(init_data);
>  	return ret;
>  
>  err:
>  	mfd_remove_devices(tps65910->dev);
>  	kfree(tps65910);
> +	kfree(init_data);
>  	return ret;
>  }
>  
Sorry didnt reply to this first time round.

Acked-by: Graeme Gregory <gg@...mlogic.co.uk>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/