linux-kernel - Re: [PATCH] i2c: Allow i2c_add_numbered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110705105330.63c113c8@endymion.delvare>
Date:	Tue, 5 Jul 2011 10:53:30 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-i2c@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
	linux-kernel@...r.kernel.org,
	Dirk Brandewie <dirk.brandewie@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	John Bonesio <bones@...retlab.ca>,
	Stephen Warren <SWarren@...dia.com>
Subject: Re: [PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus
 id.

Hi Grant,

Sorry for the late answer.

On Mon, 27 Jun 2011 13:02:45 -0600, Grant Likely wrote:
> On Mon, Jun 27, 2011 at 12:55 PM, Grant Likely
> <grant.likely@...retlab.ca> wrote:
> > Currently, if an i2c bus driver supports both static and dynamic bus
> > ids, it needs to choose between calling i2c_add_numbered_adapter() and
> > i2c_add_adapter().  This patch makes i2c_add_numbered_adapter()
> > redirect to i2c_add_adapter() if the requested bus id is -1.
> >
> > Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> 
> Oops, forgot to edit the email before sending the patch.
> 
> This patch is as-yet untested other than build testing, but I want to
> get feedback.  With the move to DT on ARM, there are going to be a lot
> more i2c bus drivers that need to support both static and dynamically
> allocated busses, and it is very likely that it will be needed in the
> v3.1 merge window.
> 
> Ben/Jean, *IF* this patch tests out okay, and *IF* I get an ack from
> you, it will probably need to have this commit in my devicetree/next
> branch.  If so, then I'll either need to commit it myself, or have it
> put into a separate topic branch that both of us can merge into our
> trees.  What is your preference.
> 
> John: this is the patch that I asked you to write earlier today, but I
> think one of the TI folks will run into the same issue, so I wanted to
> get it drafted and onto the list ASAP.

If this makes your life easier then I have no objection, you can go
ahead. I don't expect any conflict with my tree as there is no i2c-core
work going on on my end at the moment. So you can just take it in your
tree and merge it yourself as you see fit.

Acked-by: Jean Delvare <khali@...ux-fr.org>

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/