lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jul 2011 13:58:48 +0200 From: Arnd Bergmann <arnd@...db.de> To: Vitaly Kuzmichev <vkuzmichev@...sta.com> Cc: linux-arm-kernel@...ts.infradead.org, linux-watchdog@...r.kernel.org, Russell King <linux@....linux.org.uk>, Marc Zyngier <marc.zyngier@....com>, Wim Van Sebroeck <wim@...ana.be>, arm@...nel.org, linux-kernel@...r.kernel.org, John Stultz <johnstul@...ibm.com>, Nicolas Pitre <nico@...xnic.net>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH V2 6/6] mpcore_wdt: Move declarations in a separate header On Tuesday 05 July 2011, Vitaly Kuzmichev wrote: > Signed-off-by: Vitaly Kuzmichev <vkuzmichev@...sta.com> > --- > drivers/watchdog/mpcore_wdt.c | 26 +------------------------- > drivers/watchdog/mpcore_wdt.h | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 25 deletions(-) > create mode 100644 drivers/watchdog/mpcore_wdt.h I don't see the point in this. IMHO it's better to leave the definitions in the same file that uses them, because they are not shared across multiple files. If you intend to share them in the future, you should explain that in the changelog. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists