linux-kernel - Re: [PATCH V2 3/6] mpcore_wdt: Fix WDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110706131800.GJ29245@infomag.iguana.be>
Date:	Wed, 6 Jul 2011 15:18:00 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Vitaly Kuzmichev <vkuzmichev@...sta.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-watchdog@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Marc Zyngier <marc.zyngier@....com>, arm@...nel.org,
	linux-kernel@...r.kernel.org, John Stultz <johnstul@...ibm.com>,
	Nicolas Pitre <nico@...xnic.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Wolfram Sang <w.sang@...gutronix.de>
Subject: Re: [PATCH V2 3/6] mpcore_wdt: Fix WDIOC_SETOPTIONS handling

Hi Arnd,

> > According to the include/linux/watchdog.h WDIOC_SETOPTIONS is
> > classified as 'read from device' ioctl call:
> >   #define WDIOC_SETOPTIONS        _IOR(WATCHDOG_IOCTL_BASE, 4, int)
> > 
> > However, the driver 'mpcore_wdt' performs 'copy_from_user' only if
> > _IOC_WRITE is set, thus the local variable 'uarg' which is used in
> > WDIOC_SETOPTIONS handling remains uninitialized.
> > 
> > The proper way to fix this is to bind WDIOC_SETOPTIONS to _IOW,
> > but this will break compatibility.
> > So adding additional condition for performing 'copy_from_user'.
> > 
> > Signed-off-by: Vitaly Kuzmichev <vkuzmichev@...sta.com>
> 
> Is the new watchdog driver core ready for 3.1? If so, the best
> solution would be to get rid of the entire ioctl function in
> the mpcore_wdt driver and just use the core for that.
> 
> Otherwise, this patch is probably the best solution in the meantime.

Might be a correct fix in the mean time.
But goal is to have core ready for inclusion in 3.1 .
Wolfram is doing conversion of 3 drivers and writing a Howto for doing the conversions.
I'm improving the core based on what Wolfram finds during the conversions.
You may expect a (hopefully) last series of the patches this week.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/