linux-kernel - RE: [PATCH 2/2] watchdog: mpcore_wdt Add reload value setting for CNS3xxx hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 07:54:49 -0700
From:	"Lin, Tommy" <Tommy.Lin@...iumnetworks.com>
To:	"Anton Vorontsov" <cbouatmailru@...il.com>
Cc:	"Tommy Lin" <tommy.lin.1101@...il.com>,
	"Wim Van Sebroeck" <wim@...ana.be>,
	<linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Lin, Mac" <Mac.Lin@...iumnetworks.com>
Subject: RE: [PATCH 2/2] watchdog: mpcore_wdt Add reload value setting for CNS3xxx hardware

I am thinking that mpcore_wdt should work even SMP is not turned on. Did the dependency 
is neccesarry between mpcore_wdt and SMP? If CPU1 is turned off the mpcore_wdt worked
well with CPU0 only.

Best regards,
Tommy



-----Original Message-----
From: Anton Vorontsov [mailto:cbouatmailru@...il.com]
Sent: 7/6/2011 [星期三] 7:46 下午
To: Lin, Tommy
Cc: 'Tommy Lin'; 'Wim Van Sebroeck'; linux-watchdog@...r.kernel.org; linux-kernel@...r.kernel.org; Lin, Mac
Subject: Re: [PATCH 2/2] watchdog: mpcore_wdt Add reload value setting for CNS3xxx hardware
 
On Wed, Jul 06, 2011 at 03:28:30PM +0400, Anton Vorontsov wrote:
> On Wed, Jul 06, 2011 at 03:16:16PM +0400, Anton Vorontsov wrote:
> > On Wed, Jul 06, 2011 at 06:05:37PM +0800, Tommy Lin wrote:
> > > Hi, I just found another patch that can solve the watchdog counter reload
> > > issue. Please ignore this patch, since it should not acceptable to use
> > > #ifdefs.
> > 
> > OK, great. Do I understand correctly that without Vitaly's patch,
> > your first patch is somewhat useless, as the watchdog will not work
> > or will work incorrectly? So should I postpone merging patch 1/2
> > until Vitaly's patch hit mainline?
> 
> Oh, I see that the issue isn't major, so I'll just merge the first
> patch.

Heh. Nope. It doesn't work without SMP:

warning: (ARCH_CNS3XXX) selects HAVE_ARM_TWD which has unmet direct dependencies (SMP)

And SMP support is not in the mainline, yet.

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/