linux-kernel - Re: [PATCH] kernel: prevent unnecessary rebuilding due to config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110706083329.9755dc70.rdunlap@xenotime.net>
Date:	Wed, 6 Jul 2011 08:33:29 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Peter Foley <pefoley2@...izon.net>, Michal Marek <mmarek@...e.cz>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: prevent unnecessary rebuilding due to
 config_data.gz

On Tue, 05 Jul 2011 19:42:18 -0400 (EDT) Peter Foley wrote:

> When IKCONFIG is built-in make oldconfig will cause the kernel to be 
> relinked even if .config didn't change. This happens because of a 
> config_data.gz dependency on .config. This patch changes the if_changed to 
> a filechk so that config_data.h is only rebuilt when the contents 
> have actually changed.
> 
> Signed-off-by: Peter Foley <pefoley2@...izon.net>

Michal,
If this looks OK to you, please merge it.

Thanks.

> ---
>  kernel/Makefile |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 2d64cfc..d06467f 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -125,11 +125,10 @@ targets += config_data.gz
>  $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE
>  	$(call if_changed,gzip)
>  
> -quiet_cmd_ikconfiggz = IKCFG   $@
> -      cmd_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
> +      filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;")
>  targets += config_data.h
>  $(obj)/config_data.h: $(obj)/config_data.gz FORCE
> -	$(call if_changed,ikconfiggz)
> +	$(call filechk,ikconfiggz)
>  
>  $(obj)/time.o: $(obj)/timeconst.h
>  
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/