linux-kernel - Re: [PATCH 2/2] Staging: comedi: fix WARNING issue in icp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 08:59:39 -0700
From:	Greg KH <gregkh@...e.de>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 2/2] Staging: comedi: fix WARNING issue in icp_multi.c

On Wed, Jul 06, 2011 at 12:03:46PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@...enturtles.in>
> 
> This is a patch to the icp_multi.c file that fixes up a WARNING found by the checkpatch.pl tool

What warning?

> 
> Signed-off-by: Ravishankar <ravishankarkm32@...il.com>
> ---
>  drivers/staging/comedi/drivers/icp_multi.c |   13 ++++++-------
>  1 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/icp_multi.c b/drivers/staging/comedi/drivers/icp_multi.c
> index 126550f..78f33e7 100644
> --- a/drivers/staging/comedi/drivers/icp_multi.c
> +++ b/drivers/staging/comedi/drivers/icp_multi.c
> @@ -59,13 +59,12 @@ Options:
>  #include "icp_multi.h"
>  
>  #define DEVICE_ID	0x8000	/* Device ID */
> +#define ICP_MULTI_EXTDEBUG	/*       */
>  
> -#define ICP_MULTI_EXTDEBUG
> +/* Hardware types of the cards */
> +#define TYPE_ICP_MULTI 0
>  
> -/*  Hardware types of the cards */
> -#define TYPE_ICP_MULTI	0
> -
> -#define IORANGE_ICP_MULTI 	32
> +#define IORANGE_ICP_MULTI 32

These changes did not fix up any "warning", why did you make them?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/