linux-kernel - Re: [patch] regulator/tps65912: storing error codes in u8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110706183208.GK3021@sortiz-mobl>
Date:	Wed, 6 Jul 2011 20:32:08 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Liam Girdwood <lrg@...nel.org>
Cc:	Dan Carpenter <error27@...il.com>, Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	open list <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] regulator/tps65912: storing error codes in u8

Hi Liam,

On Mon, Jul 04, 2011 at 05:06:58PM +0100, Liam Girdwood wrote:
> On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> > get_ctrl_reg() returns -EINVAL so the error handling won't work here
> > if reg is a u8.
> > 
> > Signed-off-by: Dan Carpenter <error27@...il.com>
> > 
> > diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> > index d2c6542..3a9313e 100644
> > --- a/drivers/regulator/tps65912-regulator.c
> > +++ b/drivers/regulator/tps65912-regulator.c
> > @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> >  	struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> >  	struct tps65912 *mfd = pmic->mfd;
> >  	int id = rdev_get_id(dev);
> > -	u8 reg;
> > +	int reg;
> >  
> >  	if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> >  		return -EINVAL;
> 
> Samuel, would you mind taking this since tps65912 is upstreaming via
> mfd.
Sure. Would you mind sending the patch to me ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/