linux-kernel - Re: [PATCH v3 14/19] KVM: MMU: clean up spte updating and clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E14B511.5000408@cn.fujitsu.com>
Date:	Thu, 07 Jul 2011 03:18:41 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v3 14/19] KVM: MMU: clean up spte updating and clearing

On 07/07/2011 01:39 AM, Marcelo Tosatti wrote:
 
>> -static bool spte_is_bit_cleared(u64 old_spte, u64 new_spte, u64 bit_mask)
>> +static void track_spte_bits(u64 old_spte, u64 keep_bits, bool always_track)
>>  {
>> -	return (old_spte & bit_mask) && !(new_spte & bit_mask);
>> +	if (always_track ||
>> +	      (spte_is_bit_cleared(old_spte, keep_bits, shadow_accessed_mask)))
>> +		kvm_set_pfn_accessed(spte_to_pfn(old_spte));
>> +
>> +	if (always_track ||
>> +	      (spte_is_bit_cleared(old_spte, keep_bits, shadow_dirty_mask)))
>> +		kvm_set_pfn_dirty(spte_to_pfn(old_spte));
>> +}
> 
> This is much more confusing than previously, please drop it.
> 

What about remove "always_track" parameter? After that, the code should be clear.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/