linux-kernel - Re: [PATCH] Staging: msm: fixed style issues found by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110706192656.GA30532@suse.de>
Date:	Wed, 6 Jul 2011 12:26:56 -0700
From:	Greg KH <gregkh@...e.de>
To:	Prashant Shah <pshah.mumbai@...il.com>,
	Stepan Moskovchenko <stepanm@...eaurora.org>,
	David Brown <davidb@...eaurora.org>,
	Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
	Daniel Walker <dwalker@...eaurora.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: msm: fixed style issues found by checkpatch.pl

On Wed, Jul 06, 2011 at 09:45:08PM +0530, Prashant Shah wrote:
> Hi,
> 
> > So that would be one patch for fixing extra braces, one for extra
> > spaces, and so on.  That makes it easier to review.
> 
> Ok I will redo them.
> 
> On Wed, Jul 6, 2011 at 9:27 PM, Greg KH <gregkh@...e.de> wrote:
> > On Wed, Jul 06, 2011 at 01:19:34PM +0530, Prashant P. Shah wrote:
> > Also, did you successfully build this code before and after your
> > changes?
> 
> I tried but the code does not build because of #include <mach/board.h>
> in the msm_fb.c file. I dont know how to fix that.

I say let's just delete this whole directory as if it doesn't build, no
one is using it, and no one has tried to clean it up since it was
originally added.

Stepan or David or Abhijeet or Daniel, any objection to just deleting
drivers/staging/msm/ at this point in time for the 3.1 kernel release?
You haven't sent any patches to me to clean this code up since the
original patch, way over a year ago.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/