lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jul 2011 20:42:28 -0700 From: Greg KH <greg@...ah.com> To: KY Srinivasan <kys@...rosoft.com> Cc: "gregkh@...e.de" <gregkh@...e.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, "virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>, Haiyang Zhang <haiyangz@...rosoft.com>, Hank Janssen <hjanssen@...rosoft.com> Subject: Re: [PATCH 15/77] Staging: hv: blkvsc: Add the appropriate MODULE_ALIAS() line On Wed, Jul 06, 2011 at 12:40:42AM +0000, KY Srinivasan wrote: > > > diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c > > > index 5842db8..9496abe 100644 > > > --- a/drivers/staging/hv/blkvsc_drv.c > > > +++ b/drivers/staging/hv/blkvsc_drv.c > > > @@ -1027,5 +1027,6 @@ static void __exit blkvsc_exit(void) > > > MODULE_LICENSE("GPL"); > > > MODULE_VERSION(HV_DRV_VERSION); > > > MODULE_DESCRIPTION("Microsoft Hyper-V virtual block driver"); > > > +MODULE_ALIAS("vmbus:hv_block"); > > > > No, these should be automagically generated with the MODULE_DEVICE_ID() > > macro that you use in the module with the GUID there, instead of this. > > I think you mean MODULE_DEVICE_TABLE()? Yes, sorry for the typo. > I actually went down that path first > adding code to file2alias.c for parsing the vmbus ID table. Given that this approach > would make it impossible to support auto-loading of these drivers > on many of the released kernels, Wait, what? What is a "released kernel"? We are working on the in-kernel patch, we don't care about older distros/releases for this work at all. Also, it doesn't make sense at all, why would the change I asked for make any difference on older distros/kernels? > I chose to go with the MODULE_ALIAS() macro that did not need any > changes outside our drivers. In both methods, the formatting of the > name is bus specific since I would be writing the code to parse the > table in file2alias.c. Yes, that is what is needed to be done. > Granted, I have been quite unimaginative in my alias names, but I > thought they were reasonably descriptive. If at all possible, for the > reasons listed above, I would prefer to use the MODULE_ALIAS() macro > (I could embed all or part of the guid in the alias). Let me know. Please do the correct thing and use MODULE_DEVICE_TABLE(). thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists