linux-kernel - Re: [PATCH v4] ARM: Use generic BUG() handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110706200607.GS8286@n2100.arm.linux.org.uk>
Date:	Wed, 6 Jul 2011 21:06:07 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Simon Glass <sjg@...omium.org>
Cc:	Olof Johansson <olof@...om.net>,
	Stephen Boyd <sboyd@...eaurora.org>,
	anish singh <anish198519851985@...il.com>,
	lak <linux-arm-kernel@...ts.infradead.org>,
	Tony Lindgren <tony@...mide.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Joe Perches <joe@...ches.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Alexander Shishkin <virtuoso@...nd.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	Rabin Vincent <rabin@....in>,
	lk <linux-kernel@...r.kernel.org>,
	Omar Ramirez Luna <omar.ramirez@...com>,
	Dave Martin <dave.martin@...aro.org>
Subject: Re: [PATCH v4] ARM: Use generic BUG() handler

On Thu, May 19, 2011 at 10:24:31PM -0700, Simon Glass wrote:
> On Mon, Apr 25, 2011 at 6:47 PM, Olof Johansson <olof@...om.net> wrote:
> > On Wed, Apr 20, 2011 at 11:01:59AM -0700, Stephen Boyd wrote:
> >
> >> It's here:
> >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6885/1
> >>
> >> I imagine it will be added when/if Russell picks it up. Sadly it
> >> increases the LOC in ARM so Simon might need to really
> >> sell it to get it merged.
> >
> > It's core code though, and the concern today is not with ARM core code
> > as much as with the various platforms that are growing seemingly without
> > upper bounds.
> 
> Hi,
> 
> Can anyone advise please what happens next with this patch? So far I
> have posted it to the list, it has been reviewed on the list and I
> have put it into the patch system. What is the next step please to get
> this into the kernel?

Sorry, I've finally got back to looking at this.

+               ".pushsection .rodata.str, \"aMS\", 1\n"        \

According to my gas manual:

| 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]'
| ...
|    This directive pushes the current section (and subsection) onto the
| top of the section stack, and then replaces the current section and
| subsection with `name' and `subsection'. The optional `flags', `type'
| and `arguments' are treated the same as in the `.section' (*note
| Section::) directive.
| 
| 7.94 `.section NAME'
| ...
| ELF Version
| ...
|    Note on targets where the `@' character is the start of a comment (eg
| ARM) then another character is used instead.  For example the ARM port
| uses the `%' character.
| 
|    If FLAGS contains the `M' symbol then the TYPE argument must be
| specified as well as an extra argument--ENTSIZE--like this:
| 
|      .section NAME , "FLAGS"M, @TYPE, ENTSIZE
| 
|    Sections with the `M' flag but not `S' flag must contain fixed size
| constants, each ENTSIZE octets long. Sections with both `M' and `S'
| must contain zero terminated strings where each character is ENTSIZE
| bytes long. The linker may remove duplicates within sections with the
| same name, same entity size and same flags.  ENTSIZE must be an
| absolute expression.

It appears that the TYPE argument is missing.  As the GAS manual says
its required, then I think it really ought to be there.  Any comment?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/