linux-kernel - [PATCH] x86: Don't use the EFI reboot method by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1309985557-15350-1-git-send-email-mjg@redhat.com>
Date:	Wed,  6 Jul 2011 16:52:37 -0400
From:	Matthew Garrett <mjg@...hat.com>
To:	x86@...nel.org
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>
Subject: [PATCH] x86: Don't use the EFI reboot method by default

Testing suggests that at least some Lenovos and some Intels will fail
to reboot via EFI, attempting to jump to an unmapped physical address.
In the long run we could handle this by providing a page table with a
1:1 mapping of physical addresses, but for now it's probably just easier
to assume that ACPI or legacy methods will be present and reboot via those.

Signed-off-by: Matthew Garrett <mjg@...hat.com>
---
 arch/x86/platform/efi/efi.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 06f6666..4f26568 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -540,9 +540,6 @@ void __init efi_init(void)
 	x86_platform.set_wallclock = efi_set_rtc_mmss;
 #endif
 
-	/* Setup for EFI runtime service */
-	reboot_type = BOOT_EFI;
-
 #if EFI_DEBUG
 	print_efi_memmap();
 #endif
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/