linux-kernel - Re: [PATCH] FDPIC: Fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 14:16:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, uclinux-dev@...inux.org,
	Davidlohr Bueso <dave@....org>, stable@...nel.org
Subject: Re: [PATCH] FDPIC: Fix memory leak

On Wed, 06 Jul 2011 12:26:05 +0100
David Howells <dhowells@...hat.com> wrote:

> From: Davidlohr Bueso <dave@....org>
> 
> The shdr4extnum variable isn't being freed in the cleanup process of
> elf_fdpic_core_dump().
> 
> Signed-off-by: Davidlohr Bueso <dave@....org>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  fs/binfmt_elf_fdpic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index 63039ed..2bc5dc6 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1864,6 +1864,7 @@ cleanup:
>  	kfree(psinfo);
>  	kfree(notes);
>  	kfree(fpu);
> +	kfree(shdr4extnum);
>  #ifdef ELF_CORE_COPY_XFPREGS
>  	kfree(xfpu);
>  #endif

So if it dumps core often enough, the machine runs out of memory and
dies.  I added a cc:stable to my copy of this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/