linux-kernel - Re: [PATCH] spi/tegra: Use engineering names in DT compatible property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110706053859.GD9978@ponder.secretlab.ca>
Date:	Tue, 5 Jul 2011 23:38:59 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Stephen Warren <swarren@...dia.com>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-tegra@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] spi/tegra: Use engineering names in DT compatible
 property

On Tue, Jul 05, 2011 at 02:18:02PM -0600, Stephen Warren wrote:
> Engineering names are more stable than marketing names. Hence, use them
> for Device Tree compatible properties instead.
> 
> Signed-off-by: Stephen Warren <swarren@...dia.com>
> ---
> Grant, this is against devicetree/arm, and also makes sense for
> devicetree/test.

Applied to spi/next, thanks.

g.

> 
>  .../devicetree/bindings/spi/spi_nvidia.txt         |    2 +-
>  drivers/spi/spi_tegra.c                            |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi_nvidia.txt b/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> index bde450b..6b9e518 100644
> --- a/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> +++ b/Documentation/devicetree/bindings/spi/spi_nvidia.txt
> @@ -1,5 +1,5 @@
>  NVIDIA Tegra 2 SPI device
>  
>  Required properties:
> -- compatible : should be "nvidia,tegra250-spi".
> +- compatible : should be "nvidia,tegra20-spi".
>  - gpios : should specify GPIOs used for chipselect.
> diff --git a/drivers/spi/spi_tegra.c b/drivers/spi/spi_tegra.c
> index 1e7de98..b0e3586 100644
> --- a/drivers/spi/spi_tegra.c
> +++ b/drivers/spi/spi_tegra.c
> @@ -598,7 +598,7 @@ MODULE_ALIAS("platform:spi_tegra");
>  
>  #ifdef CONFIG_OF
>  static struct of_device_id spi_tegra_of_match_table[] __devinitdata = {
> -	{ .compatible = "nvidia,tegra250-spi", },
> +	{ .compatible = "nvidia,tegra20-spi", },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, spi_tegra_of_match_table);
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/