linux-kernel - Re: [PATCH] panic, vt: do not force oops output when panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110707085341.200a3c2b@lxorguk.ukuu.org.uk>
Date:	Thu, 7 Jul 2011 08:53:41 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mandeep Singh Baines <msb@...omium.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Huang Ying <ying.huang@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Hugh Dickins <hughd@...omium.org>,
	Olaf Hering <olaf@...fle.de>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Dave Airlie <airlied@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] panic, vt: do not force oops output when panic_timeout
 < 0

> a serial port. When I disabled the serial out, my machine started to
> get wedged on a panic. I guess screen_unblank was in bust_spinlocks
> for a reason. It probably bust some spin_locks somewhere.

No something else is wrong here. The console panic should be reliably
breaking the locks but a quick test of taking the console lock and BUG()
on a current kernel shows something has broken this.

> Below is a replacement for this patch which calls screen_unblank but
> does not force output when the panic timeout is negative (no wait).

The on screen console is not always just a vt, and some people log remote
management console output so we really really don't want to do this.

Instead the bug in the lock busting needs fixing. To start with it will
be hiding a ton of other oopses/bugs as hangs.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/