linux-kernel - Re: [PATCH 2/2] dmaengine: remove ste_dma40 from issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKnu2MoqGjgvVhSRQz_+bP=ErhaXp5+Rn0N+ui7F7SFmw=Q7vQ@mail.gmail.com>
Date:	Thu, 7 Jul 2011 16:27:47 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Vinod Koul <vkoul@...radead.org>
Cc:	Per Forlin <per.forlin@...aro.org>, linux-kernel@...r.kernel.org,
	Rabin Vincent <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH 2/2] dmaengine: remove ste_dma40 from issue_pending TODO

2011/7/7 Vinod Koul <vkoul@...radead.org>:
> On Sun, 2011-06-26 at 23:29 +0200, Per Forlin wrote:
>> ste_dma40 now implements issue_pending according to documentation.
>> Submit adds descriptos to a pending queue with are flushed down to the DMAC
>> at issue_pending.
>>
>> Signed-off-by: Per Forlin <per.forlin@...aro.org>
> How about the client driver which are currently using this driver, wont
> they break as they would be calling submit and not issue_pending...?

They all call both, so it works fine. First submit() then issue_pending()
in sucession.

In-tree drivers:
drivers/tty/serial/amba-pl011.c
drivers/mmc/host/mmci.c
drivers/spi/spi-pl022.c

So:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/