linux-kernel - [PATCH 3/3] uml: os-Linux/main.c memory leak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2011 19:37:48 +0300
From:	Vitaliy Ivanov <vitalivanov@...il.com>
To:	Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>
Cc:	user-mode-linux-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>, vitalivanov@...il.com
Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix

>>From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@...il.com>
Date: Thu, 7 Jul 2011 19:29:06 +0300
Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix

We should cleanup memory even though 'putenv' fails.

Signed-off-by: Vitaliy Ivanov <vitalivanov@...il.com>
---
 arch/um/os-Linux/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c
index fb2a97a..67fe012 100644
--- a/arch/um/os-Linux/main.c
+++ b/arch/um/os-Linux/main.c
@@ -107,8 +107,8 @@ static void setup_env_path(void)
 	snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path);
 	if (putenv(new_path)) {
 		perror("couldn't putenv to set a new PATH");
-		free(new_path);
 	}
+	free(new_path);
 }
 
 extern void scan_elf_aux( char **envp);
-- 
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/