linux-kernel - Re: [PATCH] Change hypervisor detection order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E164F51.3080301@zytor.com>
Date:	Thu, 07 Jul 2011 17:29:05 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Anupam Chanda <achanda@...ira.com>
CC:	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	stefano.stabellini@...citrix.com, jeremy.fitzhardinge@...rix.com,
	eddie.dong@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Change hypervisor detection order

On 07/07/2011 11:19 AM, Anupam Chanda wrote:
> Detect Xen before HyperV because in Viridian compatibility mode Xen presents
> itself as HyperV.
> 
> Signed-off-by: Anupam Chanda <achanda@...ira.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>  arch/x86/kernel/cpu/hypervisor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c
> index 8095f86..ca23091 100644
> --- a/arch/x86/kernel/cpu/hypervisor.c
> +++ b/arch/x86/kernel/cpu/hypervisor.c
> @@ -33,10 +33,10 @@
>  static const __initconst struct hypervisor_x86 * const hypervisors[] =
>  {
>  	&x86_hyper_vmware,
> -	&x86_hyper_ms_hyperv,
>  #ifdef CONFIG_XEN_PVHVM
>  	&x86_hyper_xen_hvm,
>  #endif
> +	&x86_hyper_ms_hyperv,
>  };
>  
>  const struct hypervisor_x86 *x86_hyper;

Any reason to not hoist it to the top?  I'm guessing Xen emulating
VMware is more likely than the opposite...
	
	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/