linux-kernel - RE: [PATCH 1/2] cpufreq: exynos4210: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Jul 2011 16:46:32 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Axel Lin' <axel.lin@...il.com>, linux-kernel@...r.kernel.org
Cc:	'Dave Jones' <davej@...hat.com>, cpufreq@...r.kernel.org
Subject: RE: [PATCH 1/2] cpufreq: exynos4210: make needlessly global symbols
 static

Axel Lin wrote:
> 
> The following symbols are needlessly defined global:
>   exynos4_verify_speed
>   exynos4_getspeed
>   exynos4_set_clkdiv
> 
> Make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Yes :)

Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/cpufreq/exynos4210-cpufreq.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-
> cpufreq.c
> index 54025fc..b7c3a84 100644
> --- a/drivers/cpufreq/exynos4210-cpufreq.c
> +++ b/drivers/cpufreq/exynos4210-cpufreq.c
> @@ -191,17 +191,17 @@ static unsigned int
> exynos4_apll_pms_table[CPUFREQ_LEVEL_END] = {
>  	((200 << 16) | (6 << 8) | 4),
>  };
> 
> -int exynos4_verify_speed(struct cpufreq_policy *policy)
> +static int exynos4_verify_speed(struct cpufreq_policy *policy)
>  {
>  	return cpufreq_frequency_table_verify(policy, exynos4_freq_table);
>  }
> 
> -unsigned int exynos4_getspeed(unsigned int cpu)
> +static unsigned int exynos4_getspeed(unsigned int cpu)
>  {
>  	return clk_get_rate(cpu_clk) / 1000;
>  }
> 
> -void exynos4_set_clkdiv(unsigned int div_index)
> +static void exynos4_set_clkdiv(unsigned int div_index)
>  {
>  	unsigned int tmp;
> 
> --
> 1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/