linux-kernel - Re: [PATCHv2] remove unnecessary cache flush on v6 copypage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110708094722.GC16293@e102109-lin.cambridge.arm.com>
Date:	Fri, 8 Jul 2011 10:47:22 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Heechul Yun <heechul@...inois.edu>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"saeed.bishara@...il.com" <saeed.bishara@...il.com>
Subject: Re: [PATCHv2] remove unnecessary cache flush on v6 copypage

On Fri, Jul 08, 2011 at 10:35:42AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 07, 2011 at 09:30:19AM -0500, Heechul Yun wrote:
> > ARM: mm: remove unnecessary cache flush on v6 copypage
> > 
> > Originally introduced to maintain coherency between icache and dcache
> > in v6 nonaliasing mode. This is now handled by __sync_icache_dcache since
> > c0177800, therefore unneceary in this function.  
> > 
> > Signed-off-by: Heechul Yun <heechul@...inois.edu>
> > Acked-by: Catalin Marinas <catalin.marinas@....com>
> > --
> > arch/arm/mm/copypage-v6.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mm/copypage-v6.c b/arch/arm/mm/copypage-v6.c
> > index bdba6c6..63cca00 100644
> > --- a/arch/arm/mm/copypage-v6.c
> > +++ b/arch/arm/mm/copypage-v6.c
> > @@ -41,7 +41,6 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to,
> >  	kfrom = kmap_atomic(from, KM_USER0);
> >  	kto = kmap_atomic(to, KM_USER1);
> >  	copy_page(kto, kfrom);
> > -	__cpuc_flush_dcache_area(kto, PAGE_SIZE);
> >  	kunmap_atomic(kto, KM_USER1);
> >  	kunmap_atomic(kfrom, KM_USER0);
> >  }
> 
> The above patch is fine (it has tabs preserved) but the version in the
> patch system has spaces instead (each space character has been replaced
> with a '.') and so doesn't apply:

Does your patch system now understand a From: line in the patch log (and
preserve the author)? I can upload the patch on Heechul's behalf.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/