linux-kernel - Re: [PATCH 02/12] gma500: Re-order checks and dereferences in psb_intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110708204414.GA28312@kroah.com>
Date:	Fri, 8 Jul 2011 13:44:14 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/12] gma500: Re-order checks and dereferences in
 psb_intel_lvds

On Fri, Jul 08, 2011 at 09:43:15AM +0100, Alan Cox wrote:
> From: Alan Cox <alan@...ux.intel.com>
> 
> Dan Carpenter reports:
> 
> Smatch complains about 6a7afe3acc4b "gma500: continue abstracting
> platform specific code"
> 
> drivers/staging/gma500/psb_intel_lvds.c +579 psb_intel_lvds_set_property(7)
> 	warn: variable dereferenced before check 'encoder'
> 
> --- a/drivers/staging/gma500/psb_intel_lvds.c
> +++ b/drivers/staging/gma500/psb_intel_lvds.c
> @@ -575,11 +575,12 @@ int psb_intel_lvds_set_property(struct drm_connector
> *connector,
>                                        struct drm_property *property,
>                                        uint64_t value)
>  {
> -       struct drm_encoder *pEncoder = connector->encoder;
> +       struct drm_encoder *encoder = connector->encoder;
> +       struct drm_psb_private *dev_priv = encoder->dev->dev_private;
>                                            ^^^^^^^^^^^^
> dereference encoder here.
> 
> Signed-off-by: Alan Cox <alan@...ux.intel.com>

Oh that played hell with git, please don't do that again...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/