linux-kernel - Re: [PATCH] dell-laptop - using buffer without mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110709212844.GA13698@farmergreg.com>
Date:	Sat, 9 Jul 2011 16:28:44 -0500
From:	Greg Dietsche <greg@...gd.org>
To:	Jose Alonso <joalonsof@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dell-laptop - using buffer without mutex_lock

Hi Jose,

On Fri, Jul 08, 2011 at 07:01:27PM -0300, Jose Alonso wrote:
> Using buffer->output[1] without mutex_lock()
> 
> --- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG
> 2011-07-04 19:56:24.000000000 -0300
> +++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c    2011-07-08
> 18:27:02.420791868 -0300
> @@ -560,11 +560,11 @@
>         else
>                 dell_send_request(buffer, 0, 1);
> 
> +       ret = buffer->output[1];
> +
>  out:
>         release_buffer();
> -       if (ret)
> -               return ret;
> -       return buffer->output[1];
> +       return ret;
>  }
> 
>  static const struct backlight_ops dell_ops = {
> 
> 
> --

You should run this patch through scripts/checkpatch.pl as it
reports a few style issues for your patch including a missing
signed-off-by line and some spaces that should be converted to tabs.

Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/