linux-kernel - Re: [PATCH] Avoid Wunused-but-set warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACqU3MUFO9DGqnK99ApaKn00vzj5rCB5=kjuSZGZpPU8c_4G-A@mail.gmail.com>
Date:	Sun, 10 Jul 2011 12:49:20 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	Raghavendra D Prabhu <rprabhu@...hang.net>,
	linux-kbuild@...r.kernel.org, Nir Tzachar <nir.tzachar@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Avoid Wunused-but-set warning

Hi,

On Sun, Jul 10, 2011 at 12:28 PM, Pekka Enberg <penberg@...nel.org> wrote:
> On Sun, Jul 10, 2011 at 7:24 PM, Arnaud Lacombe <lacombar@...il.com> wrote:
>> Hi,
>>
>> On Sun, Jul 10, 2011 at 12:16 PM, Américo Wang <xiyou.wangcong@...il.com> wrote:
>>> On Sun, Jul 10, 2011 at 12:24 AM, Raghavendra D Prabhu
>>> <rprabhu@...hang.net> wrote:
>>>> Hi,
>>>>    I am seeing Wunused-but-set warning while make nconfig.  Looks like
>>>>    active_menu is not used. Removing it fixes the warning.
>>>>
>>>> Signed-off-by: Raghavendra D Prabhu <rprabhu@...hang.net>
>>>
>>> Acked-by: WANG Cong <xiyou.wangcong@...il.com>
>>>
>> Out of curiosity, what is your status to ACK such patch ?
>
> What kind of status do you need to ACK such a simple patch?
>
As per Documentation/SubmittingPatches:

<<
13) When to use Acked-by: and Cc:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.

If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.

Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch.
>>

That said, it is not a strong requirement... unfortunately. So, let's
have some fun and go ACK thousand of trivial patch just to generate
traffic on the LKML and give myself self-importance :-)

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/