linux-kernel - Re: [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMbhsRRhBc-Ys=nBSB6kHSLUUGB3XD_unN4aG-wubYg0sFer4g@mail.gmail.com>
Date:	Sat, 9 Jul 2011 17:08:51 -0700
From:	Colin Cross <ccross@...roid.com>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Catalin Marinas <catalin.marinas@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Abhijeet Dharmapurikar <adharmap@...eaurora.org>
Subject: Re: [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags

On Sat, Jul 9, 2011 at 5:03 PM, Santosh Shilimkar
<santosh.shilimkar@...com> wrote:
> On 6/12/2011 5:45 PM, Colin Cross wrote:
>>
>> Tegra can benefit from the IRQCHIP_MASK_ON_SUSPEND flag, allow it
>> to be passed to the gic irq chip.
>>
>> Signed-off-by: Colin Cross<ccross@...roid.com>
>
> I missed this patch. Looks good to me and I think can
> be merged in rc as well.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>

There is no need for this in an rc unless another patch destined for
rc needs to set the flags, which is unlikely at this point.

>> ---
>>  arch/arm/common/gic.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
>> index 8d62e07..a6c28a0 100644
>> --- a/arch/arm/common/gic.c
>> +++ b/arch/arm/common/gic.c
>> @@ -576,6 +576,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int
>> irq_start,
>>        if (gic_nr == 0)
>>                gic_cpu_base_addr = cpu_base;
>>
>> +       gic_chip.flags |= gic_arch_extn.flags;
>>        gic_dist_init(gic, irq_start);
>>        gic_cpu_init(gic);
>>        gic_cpu_pm_init(gic);
>
> Russell,
> Any thoughts on this fix?
>
> Regards
> Santosh
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/