linux-kernel - Re: [PATCH] x86: Fix memory leak of init_vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110711100418.GC9859@elte.hu>
Date:	Mon, 11 Jul 2011 12:04:18 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	wzt wzt <wzt.wzt@...il.com>
Cc:	Andi Kleen <ak@...ux.intel.com>, Michal Hocko <mhocko@...e.cz>,
	mingo@...hat.com, linux-kernel@...r.kernel.org, x86@...nel.org,
	tglx@...utronix.de, hpa@...or.com
Subject: Re: [PATCH] x86: Fix memory leak of init_vdso_vars()


* wzt wzt <wzt.wzt@...il.com> wrote:

> maybe, we can just panic() when kmalloc failed instead of add a new 
> GFP_PANIC.
> 
> new patch will coming soon.
> 
> On Fri, Jul 8, 2011 at 2:33 AM, Andi Kleen <ak@...ux.intel.com> wrote:
> > When you run out of memory at early system boot (this is early
> > system boot only) the system is toast anyways. There's no way
> > to recover.
> >
> > I would just add a few GFP_PANICs and then drop the error paths.

That's a very sloppy way of doing it: should anyone ever want to 
reuse this function *not* in an init path (which is a future 
possibility with the vdso) it will have a nasty panic() embedded in 
it ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/