linux-kernel - Re: [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 12:07:59 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Grant Likely <grant@...retlab.ca>, linux-sh@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	Jeremy Kerr <jeremy.kerr@...onical.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks

On Mon, Jul 11, 2011 at 10:31:24AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 11, 2011 at 11:53:44AM +0900, Mark Brown wrote:
> > The biggest issue I ran into was that as the clocks are all registered
> > by name with the API if you've got two instances of the same off-SoC
> > device in the system you'll not be able to disambiguate between the
> > clocks it provides.
> 
> Sigh.  That sounds like yet more trash.  Obviously whoever thought
> up that doesn't actually understand clks.

Nope. In the patches Jeremy posted clocks have a name, but this name
is not meant to be used with clk_get. clk_get is still implemented
in clkdev, so the matching between clocks and devices is independent
of the clock name.

In earlier versions of Jeremys patches the clock name was only present
when debugfs was compiled in and I think it can be changed back to this.

That said the debugfs support (which is not present in Jeremys latest
series) would break if two clocks with the same name have the same
parent, because the clock core would try to create to debugfs entries
with the same name.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/