[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110711134147.GA6853@infradead.org>
Date: Mon, 11 Jul 2011 09:41:47 -0400
From: Christoph Hellwig <hch@...radead.org>
To: David Howells <dhowells@...hat.com>
Cc: viro@...IV.linux.org.uk, autofs@...ux.kernel.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Ian Kent <raven@...maw.net>
Subject: Re: [PATCH] VFS: Fix automount for negative autofs dentries
> + if (!(flags & LOOKUP_FOLLOW)) {
> + /* We do, however, want to mount if someone wants to open or
> + * create a file of any type under the mountpoint, wants to
> + * traverse through the mountpoint or wants to open the mounted
> + * directory.
> + */
> + if (flags & (LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
> + LOOKUP_OPEN | LOOKUP_CREATE))
> + goto need_automount;
> +
> + /* Also, autofs may mark negative dentries as being automount
> + * points. These will need the attentions of the daemon to
> + * instantiate them before they can be used.
> + */
> + if (!path->dentry->d_inode)
> + goto need_automount;
> return -EISDIR;
> + }
> +need_automount:
That's some really odd code structure.
if (!(flags & (LOOKUP_FOLLOW | LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
LOOKUP_OPEN | LOOKUP_CREATE)) &&
path->dentry->d_inode)
return -EISDIR;
would do the same.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists