linux-kernel - Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E1A5D8F.2020600@realsil.com.cn>
Date:	Mon, 11 Jul 2011 10:18:55 +0800
From:	wwang <wei_wang@...lsil.com.cn>
To:	王炜 <wei_wang@...lsil.com.cn>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp

On 2011年07月11日 10:13, 王炜 wrote:
> From: wwang<wei_wang@...lsil.com.cn>
>
> cppcheck reported: [staging/rts_pstor/sd.c:3730] ->  [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
> It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"
>
> Signed-off-by: wwang<wei_wang@...lsil.com.cn>
> ---
>   drivers/staging/rts_pstor/sd.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
> index e4b3891..8db14dd 100644
> --- a/drivers/staging/rts_pstor/sd.c
> +++ b/drivers/staging/rts_pstor/sd.c
> @@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
>   				if ((ptr[3]&  0x1E) != 0x04) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}
> -			} else if (rsp_type == SD_RSP_TYPE_R2) {
> +			} else if (rsp_type == SD_RSP_TYPE_R0) {
>   				if ((ptr[3]&  0x1E) != 0x03) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}

Dear all:

     Sorry to bother, please ignore this mail, I will modify the log 
resend again.

     Best regards,
     wwang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/