linux-kernel - Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's VID/PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1107111718100.31445@twin.jikos.cz>
Date:	Mon, 11 Jul 2011 17:19:32 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"Ice.Chien" <ice.chien@...upoint.com.tw>
Cc:	linux-kernel@...r.kernel.org, benjamin.tissoires@...c.fr,
	Jonson Wu <jonson.wu@...upoint.com.tw>
Subject: Re: [PATCH] hid-multitouch driver: add one new hid multitouch device's
 VID/PID

On Mon, 11 Jul 2011, Ice.Chien wrote:

> This is a patch to add one hid multitouch device's VID/PID in hid-ids.h
> and hid-core.c
> 
> Signed-off-by: Ice Chien <ice.chien@...upoint.com.tw>
> ---
> diff -u ./linux-2.6.39.3/drivers/hid//hid-core.c
> ./modified/drivers/hid//hid-core.c
> --- ./linux-2.6.39.3/drivers/hid//hid-core.c	2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-core.c	2011-07-11 13:36:07.784957908
> +0800
> @@ -1482,6 +1482,7 @@
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_SLIM_TABLET_12_1_INCH) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_10_6_INCH) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
> USB_DEVICE_ID_WALTOP_MEDIA_TABLET_14_1_INCH) },
> +      	{ HID_USB_DEVICE(USB_VENDOR_ID_XAT, USB_DEVICE_ID_XAT_CSR) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> diff -u ./linux-2.6.39.3/drivers/hid//hid-ids.h
> ./modified/drivers/hid//hid-ids.h
> --- ./linux-2.6.39.3/drivers/hid//hid-ids.h	2011-07-09
> 14:16:06.000000000 +0800
> +++ ./modified/drivers/hid//hid-ids.h	2011-07-11 13:36:05.969865971
> +0800
> @@ -607,6 +607,9 @@
>  #define USB_VENDOR_ID_WISEGROUP_LTD2	0x6677
>  #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
>  
> +#define USB_VENDOR_ID_XAT               0x2505
> +#define USB_DEVICE_ID_XAT_CSR           0x0220
> +
>  #define USB_VENDOR_ID_YEALINK		0x6993
>  #define USB_DEVICE_ID_YEALINK_P1K_P4K_B2K	0xb001
>  
> Common subdirectories: ./linux-2.6.39.3/drivers/hid//usbhid and
> ./modified/drivers/hid//usbhid

Hi,

first, your patch is line-wrapped and whitespace damaged. Please fix your 
mailclient (*) for your future (re-)submissions.

Second, the patch seems incomplete. You probably want some specific driver 
(persumably hid-multitouch?) to claim the device.

(*) see Documentation/email-clients.txt for details.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/