linux-kernel - staging/lirc_bt829: Return -ENODEV when no hardware is found.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 11:24:36 -0400
From:	Dave Jones <davej@...hat.com>
To:	lfroen@...ileo.co.il
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, greg@...ah.com
Subject: staging/lirc_bt829: Return -ENODEV when no hardware is found.

sys_init_module: 'lirc_bt829'->init suspiciously returned 1, it should follow 0/-E convention
sys_init_module: loading module anyway...
Pid: 8511, comm: modprobe Tainted: G        WC  3.0.0-rc6+ #73
Call Trace:
 [<ffffffff810b3da7>] sys_init_module+0x217/0x230
 [<ffffffff815ed1d2>] system_call_fastpath+0x16/0x1b

Signed-off-by: Dave Jones <davej@...hat.com>

diff --git a/drivers/staging/lirc/lirc_bt829.c b/drivers/staging/lirc/lirc_bt829.c
index 3388102..c5a0d27 100644
--- a/drivers/staging/lirc/lirc_bt829.c
+++ b/drivers/staging/lirc/lirc_bt829.c
@@ -122,10 +122,10 @@ int init_module(void)

 	pdev = do_pci_probe();
 	if (pdev == NULL)
-		return 1;
+		return -ENODEV;

 	if (!atir_init_start())
-		return 1;
+		return -ENODEV;

 	strcpy(atir_driver.name, "ATIR");
 	atir_driver.minor       = -1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/