linux-kernel - Re: [PATCH] PTI implicit declaration fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E1B208D.1000708@linux.intel.com>
Date:	Mon, 11 Jul 2011 09:10:53 -0700
From:	J Freyensee <james_p_freyensee@...ux.intel.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	randy.dunlap@...cle.com, sfr@...b.auug.org.au,
	christophe.guerard@...el.com, pranav.k.sanghadia@...el.com
Subject: Re: [PATCH] PTI implicit declaration fix.

On 07/09/2011 01:08 AM, Geert Uytterhoeven wrote:
> On Fri, Jul 8, 2011 at 23:34,<james_p_freyensee@...ux.intel.com>  wrote:
>> From: J Freyensee<james_p_freyensee@...ux.intel.com>
>>
>> In a certain compile configuration, functions like
>> 'kmalloc' and 'copy_from_user' were coming up as
>> implicit errors.  This patch adds slab.h and
>> uaccess.h to the driver.
>>
>> Reported-by: Geert Uytterhoeven<geert@...ux-m68k.org>
>> Acked-by: Geert Uytterhoeven<geert@...ux-m68k.org>
>
> Please don't add "Acked-by" lines before people have ack'ed your patches.
>

Okay...so should I re-send this patch out without the Acked-by in it? 
Or is it okay this time and next time please do this?

>> Signed-off-by: J Freyensee<james_p_freyensee@...ux.intel.com>
>> ---
>>   drivers/misc/pti.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
>> index 8653bd0..4ba4e5f 100644
>> --- a/drivers/misc/pti.c
>> +++ b/drivers/misc/pti.c
>> @@ -22,6 +22,8 @@
>>   */
>>
>>   #include<linux/init.h>
>> +#include<linux/slab.h>
>> +#include<linux/uaccess.h>
>>   #include<linux/sched.h>
>>   #include<linux/interrupt.h>
>>   #include<linux/console.h>
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/