linux-kernel - Re: [PATCH] cifs: drop spinlock before calling cifs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mug1iYZSGybKjg3H+kUVK6PA3XXt05-6kf+dLYH0yETBQ@mail.gmail.com>
Date:	Mon, 11 Jul 2011 11:40:12 -0500
From:	Steve French <smfrench@...il.com>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	linux-cifs@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: drop spinlock before calling cifs_put_tlink

ok - merged.

Am testing now.  If anyone else has test data on current cifs-2.6.git
I could send pull request faster.

On Mon, Jul 11, 2011 at 9:16 AM, Jeff Layton <jlayton@...hat.com> wrote:
> ...as that function can sleep.
>
> Signed-off-by: Jeff Layton <jlayton@...hat.com>
> ---
>  fs/cifs/connect.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index ceab134..dd695c5 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2241,8 +2241,8 @@ cifs_match_super(struct super_block *sb, void *data)
>
>        rc = compare_mount_options(sb, mnt_data);
>  out:
> -       cifs_put_tlink(tlink);
>        spin_unlock(&cifs_tcp_ses_lock);
> +       cifs_put_tlink(tlink);
>        return rc;
>  }
>
> --
> 1.7.6
>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/