linux-kernel - Re: [PATCH 07/21] dynamic_debug: return int from ddebug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 20:39:27 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	jbaron@...hat.com, linux-kernel@...r.kernel.org, joe@...ches.com,
	gregkh@...e.de, gnb@...h.org
Subject: Re: [PATCH 07/21] dynamic_debug: return int from ddebug_change

On Mon, Jul 11, 2011 at 9:46 AM, Jim Cromie <jim.cromie@...il.com> wrote:
> Alter ddebug_change to return number of matches found for query/rule.
> This lets caller know whether rule applied, and potentially what
> to do next.
>
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  lib/dynamic_debug.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index bbee0aa..de2a679 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -102,8 +102,8 @@ static char *ddebug_describe_flags(struct _ddebug *dp, char *buf,
>  * the user which ddebug's were changed, or whether none
>  * were matched.
>  */
> -static void ddebug_change(const struct ddebug_query *query,
> -                          unsigned int flags, unsigned int mask)
> +static int ddebug_change(const struct ddebug_query *query,
> +                       unsigned int flags, unsigned int mask)
>  {
>        int i;
>        struct ddebug_table *dt;
> @@ -167,8 +167,7 @@ static void ddebug_change(const struct ddebug_query *query,
>        }
>        mutex_unlock(&ddebug_lock);
>
> -       if (!nfound && verbose)
> -               pr_info("no matches for query\n");
> +       return nfound;
>  }
>
>  /*
> @@ -420,6 +419,7 @@ static int ddebug_exec_query(char *query_string)
>  #define MAXWORDS 9
>        int nwords;
>        char *words[MAXWORDS];
> +       int nfound;
>
>        nwords = ddebug_tokenize(query_string, words, MAXWORDS);
>        if (nwords <= 0)
> @@ -430,7 +430,7 @@ static int ddebug_exec_query(char *query_string)
>                return -EINVAL;
>
>        /* actually go and implement the change */
> -       ddebug_change(&query, flags, mask);
> +       nfound = ddebug_change(&query, flags, mask);
>        return 0;
>  }

I still see the introduction of a dead assignment in the second half
of the above patch. After the first series had been posted you had
proposed yourself to merge this patch with the subsequent patch.
Apparently that hasn't been done yet ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/