linux-kernel - Re: [PATCH next/mmotm] slub: partly fix freeze in __slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1107111339330.13756@sister.anvils>
Date:	Mon, 11 Jul 2011 13:46:42 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH next/mmotm] slub: partly fix freeze in __slab_free

On Mon, 11 Jul 2011, Eric Dumazet wrote:
> Le lundi 11 juillet 2011 à 11:58 -0700, Hugh Dickins a écrit :
> > My load tests on PowerPC freeze within minutes in __slab_free().
> > I happened to try PPC first, didn't try without this fix on x86.
> 
> I suspect you hit the bug on 32bit arch ?

No, it was ppc64.  I've not actually tried that load on mmotm 32bit
at all yet, better do so tonight!

Hugh

> 
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 3d76a43..1351d28 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -62,7 +62,7 @@ struct page {
>  		struct {			/* SLUB cmpxchg_double area */
>  			void *freelist;
>  			union {
> -				unsigned long counters;
> +				u64	counters;
>  				struct {
>  					unsigned inuse:16;
>  					unsigned objects:15;