linux-kernel - Re: [PATCH] hpsa: do not attempt to read from a write-only register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110711205124.GB25366@beardog.cce.hp.com>
Date:	Mon, 11 Jul 2011 15:51:24 -0500
From:	scameron@...rdog.cce.hp.com
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	james.bottomley@...senpartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, stephenmcameron@...il.com,
	thenzl@...hat.com, mikem@...rdog.cce.hp.com
Subject: Re: [PATCH] hpsa: do not attempt to read from a write-only register

On Mon, Jul 11, 2011 at 01:19:11PM -0700, Andrew Morton wrote:
> On Fri, 08 Jul 2011 14:59:26 -0500
> "Stephen M. Cameron" <scameron@...rdog.cce.hp.com> wrote:
> 
> > From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> > 
> > Most smartarrays tolerate it, but a few new ones don't.
> > 
> > Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> > ---
> >  drivers/scsi/hpsa.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> > index 6d8dcd4..7f53cea 100644
> > --- a/drivers/scsi/hpsa.h
> > +++ b/drivers/scsi/hpsa.h
> > @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> >  	dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> >  		c->Header.Tag.lower);
> >  	writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > -	(void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > +	(void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> >  	h->commands_outstanding++;
> >  	if (h->commands_outstanding > h->max_outstanding)
> >  		h->max_outstanding = h->commands_outstanding;
> 
> The changelog forgot to tell us the user-visible effects of the bug. 
> That was really really bad of it.  Bad changelog.  No bone for you.

Oh, sorry.  When the controller doesn't tolerate the bug, the firmware
on it locks up.  No interrupts are received, no commands complete. I/o
on that controller grinds to a halt.

I can resubmit if you like.

-- steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/