linux-kernel - [PATCH] [RFC][PATCH] Remove /proc/kallsyms size verification check in perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 15:57:49 -0700
From:	Sonny Rao <sonnyrao@...omium.org>
To:	acme@...hat.com
Cc:	rostedt@...dmis.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Sonny Rao <sonnyrao@...omium.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] [RFC][PATCH] Remove /proc/kallsyms size verification check in perf

The check was failing when I was trying to profile system startup
because the modules were being loaded and causing the size of
kallsyms to change.  At first I changed the check to simply make
sure the size of kallsyms increased, but that wouldn't cover the
case of a module getting removed (or some removed and larger ones
loaded).  I can't see any purpose to checking the size
right after reading it either, so remove the check altogether.

Signed-off-by: Sonny Rao <sonnyrao@...omium.org>
---
 tools/perf/util/trace-event-info.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 35729f4..3f1af9f 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -440,9 +440,6 @@ static void read_proc_kallsyms(void)
 	}
 	size = get_size(path);
 	write_or_die(&size, 4);
-	check_size = copy_file(path);
-	if (size != check_size)
-		die("error in size of file '%s'", path);
 
 }
 
-- 
1.7.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/