linux-kernel - Re: [PATCH 3/3] Staging: comedi: fix brace coding style issue in pcl818.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1310363858.2446.15.camel@Joe-Laptop>
Date:	Sun, 10 Jul 2011 22:57:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 3/3] Staging: comedi: fix brace coding style issue in
 pcl818.c

On Mon, 2011-07-11 at 11:30 +0530, Ravishankar wrote:
> This is a patch to the pcl818.c file that fixes up a brace warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
[]
> @@ -1301,11 +1301,10 @@ static void setup_channel_list(struct comedi_device *dev,
>  */
>  static int check_single_ended(unsigned int port)
>  {
> -	if (inb(port + PCL818_STATUS) & 0x20) {
> +	if (inb(port + PCL818_STATUS) & 0x20)
>  		return 1;
> -	} else {
> +	else
>  		return 0;
> -	}
>  }

I'd prefer this become:

static bool check_single_ended()
{
	if (...)
		return true;
	return false;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/