linux-kernel - Re: [09/35] ath9k: Fix suspend/resume when no interface is UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110711052117.GA797@vmraj-lnx.users.atheros.com>
Date:	Mon, 11 Jul 2011 10:51:18 +0530
From:	Rajkumar Manoharan <rmanohar@....qualcomm.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Greg KH <gregkh@...e.de>, <linux-kernel@...r.kernel.org>,
	<stable@...nel.org>, <stable-review@...nel.org>,
	<torvalds@...ux-foundation.org>, <akpm@...ux-foundation.org>,
	<alan@...rguk.ukuu.org.uk>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [09/35] ath9k: Fix suspend/resume when no interface is UP

On Sat, Jul 09, 2011 at 11:58:18AM -0400, Paul Gortmaker wrote:
> On Fri, Jul 8, 2011 at 6:49 PM, Greg KH <gregkh@...e.de> wrote:
> > 2.6.32-longterm review patch.  If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > From: Rajkumar Manoharan <rmanohar@....qualcomm.com>
> >
> > commit c31eb8e926835582cd186b33a7a864880a4c0c79 upstream.
> >
> > When no interface has been brought up, the chip's power
> > state continued as AWAKE. So during resume, the chip never
> > been powered up.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@....qualcomm.com>
> > Signed-off-by: John W. Linville <linville@...driver.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> >
> > ---
> >  drivers/net/wireless/ath/ath9k/pci.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > --- a/drivers/net/wireless/ath/ath9k/pci.c
> > +++ b/drivers/net/wireless/ath/ath9k/pci.c
> > @@ -276,6 +276,12 @@ static int ath_pci_resume(struct pci_dev
> 
> This might warrant a double check.   The original was patching the
> fullsleep into pci_suspend, not pci_resume, as is shown above here.
> 
Thanks Paul for pointing out.

> >                            AR_GPIO_OUTPUT_MUX_AS_OUTPUT);
> >        ath9k_hw_set_gpio(sc->sc_ah, sc->sc_ah->led_pin, 1);
> >
> > +       /* The device has to be moved to FULLSLEEP forcibly.
> > +        * Otherwise the chip never moved to full sleep,
> > +        * when no interface is up.
> > +        */
> > +       ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_FULL_SLEEP);
> > +
> >        return 0;
> >  }
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/