linux-kernel - Re: xen-blkfront: Don't send closing notification to backend in blkfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110712150409.GB7831@dumpdata.com>
Date:	Tue, 12 Jul 2011 11:04:09 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Joe Jin <joe.jin@...cle.com>, Jens Axboe <jaxboe@...ionio.com>
Cc:	Daniel Stodden <daniel.stodden@...rix.com>,
	Jens Axboe <jaxboe@...ionio.com>, annie.li@...cle.com,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	Kurt C Hackel <KURT.HACKEL@...cle.com>,
	Greg Marsden <greg.marsden@...cle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: xen-blkfront: Don't send closing  notification to backend in
 blkfront_closing()

> without the patch, after detach the device by xm block-detach timeout also umount hang in guest.
> with my patch, xm block-detach timeout in Dom0, umount in guest worked!

Ah, I failed to spot you did the unmount after the timeout. I tried to do the umount after
forcing the block-detach. [and testing confirms your patch working properly]

Looks good to me - with the only exception that the description needs to have 'xm block-attach'
and 'xm block-detach' - please change that and resubmit and attach

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC: stable@...nel.org

and make sure to have Jens in the 'To:' header.
Thanks!


Jens,

Are you OK picking the amended patch (shortly to be posted) for 3.0-rc7?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/