[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACqU3MUXAOMGQ1nzUrtYPEQAC3U-nuq3YurtNJJLS1hft4ROGA@mail.gmail.com>
Date: Tue, 12 Jul 2011 14:49:42 -0400
From: Arnaud Lacombe <lacombar@...il.com>
To: Anders Kaseorg <andersk@...lice.com>
Cc: Alessio Igor Bogani <abogani@...nel.org>,
Rusty Russell <rusty@...tcorp.com.au>,
Jan Beulich <jbeulich@...ell.com>,
Kbuild <linux-kbuild@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Tim Bird <tim.bird@...sony.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V2
Hi,
On Tue, Jul 12, 2011 at 2:35 PM, Anders Kaseorg <andersk@...lice.com> wrote:
> On Tue, Jul 12, 2011 at 14:15, Arnaud Lacombe <lacombar@...il.com> wrote:
>> modpost is an host tool, it should not include kernel header. Content
>> of this file is not exported to userland anyway.
>
> My point was more that you might as well reuse the same name and
> probably the same code so that people don’t have to look carefully at
> a new macro to decide whether it’s off-by-one from what they expect.
>
Agree. I was not entirely sure of what you meant, ie. whether
including "include/linux/string.h" or adjusting the name and
definition to match the existing. So I thought it would just be better
to clear any potential misunderstanding :)
- Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists