linux-kernel - Re: [PATCH 21/21] dynamic_debug: delete pending queries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110712205000.GA2500@redhat.com>
Date:	Tue, 12 Jul 2011 16:50:01 -0400
From:	Jason Baron <jbaron@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org,
	bvanassche@....org, gregkh@...e.de, gnb@...h.org
Subject: Re: [PATCH 21/21] dynamic_debug: delete pending queries

On Mon, Jul 11, 2011 at 05:25:35PM -0700, Joe Perches wrote:
> On Mon, 2011-07-11 at 01:46 -0600, Jim Cromie wrote:
> > delete pending queries by re-issuing it with disabled flags
> []
> > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> []
> > @@ -505,7 +505,17 @@ static int ddebug_save_pending(struct ddebug_query *query,
> >  
> >  	list_for_each_entry_safe(pq, pqnext, &pending_queries, link) {
> >  		if (queries_match(query, &pq->query)) {
> > -			/* query already in list, update flags */
> > +			/* query already in list */
> > +			if (!flags) {
> > +				/* zeroed flags, remove query */
> > +				if (verbose)
> > +					pr_info("delete pending: %s\n",
> > +						show_pending_query(pq));
> 
> I think these should be pr_debug.
> I know you're only using the current style.
> 
> Jason, any reason these can not be converted?
> 

it should be ok, although we have to be careful not to use them in the
printing path, since that will cause a recursion.

Also, if there is an issue with the dynamic debug code, it makes it more
of a pain to debug :)

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/