lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201107122308.26080.arnd@arndb.de>
Date:	Tue, 12 Jul 2011 23:08:25 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...e.de, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 3/3] TTY: serial, remove tasklet for tty_wakeup

On Tuesday 12 July 2011 22:43:20 Jiri Slaby wrote:
> tty_wakeup can be called from any context. So there is no need to have
> an extra tasklet for calling that. Hence save some space and remove
> the tasklet completely.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Alan Cox <alan@...ux.intel.com>

This is probably ok, but strictly speaking, we we cannot call 
tty_wakeup from any context: not while holding the ldisc_mutex,
i.e. from  ld->ops->{open,close}.

I don't see a reason why we would ever do that, but it's the
only explanation I have why the tasklet was introduced intially.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ