linux-kernel - Re: [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABkP77d8K1Of7jw8hpyi_XG+xorZ8OKkgoGfSy9_zh7iSq5kFA@mail.gmail.com>
Date:	Tue, 12 Jul 2011 09:38:16 +0200
From:	Fabio Baltieri <fabio.baltieri@...il.com>
To:	Scott Wood <scottwood@...escale.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Poonam Aggrwal <poonam.aggrwal@...escale.com>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode

On Mon, Jul 11, 2011 at 9:38 PM, Scott Wood <scottwood@...escale.com> wrote:
> On Sun, 10 Jul 2011 20:55:32 +0200
> Fabio Baltieri <fabio.baltieri@...il.com> wrote:
>
>> Change the string to check for CAMP mode boot on MPC85xx (eg. P2020) to match
>> the one in the corresponding dts files (p2020rdb_camp_core{0,1}.dts).
>>
>> Without this fix the mpic is configured as in the SMP boot mode, which causes
>> the first core to report a protected source interrupt error for devices
>> of the other core and lock up.
>>
>> Signed-off-by: Fabio Baltieri <fabio.baltieri@...il.com>
>> ---
>>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
>> b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
>> index 088f30b..a1e5e70 100644
>> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
>> @@ -58,7 +58,7 @@ void __init mpc85xx_rdb_pic_init(void)
>>               return;
>>       }
>>
>> -     if (of_flat_dt_is_compatible(root, "fsl,85XXRDB-CAMP")) {
>> +     if (of_flat_dt_is_compatible(root, "fsl,MPC85XXRDB-CAMP")) {
>>               mpic = mpic_alloc(np, r.start,
>>                       MPIC_PRIMARY |
>>                       MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS,
>
> Shouldn't we be setting MPIC_SINGLE_DEST_CPU in this case (as we do for
> the other case)?
>
> Or just drop this and specify pic-no-reset in the mpic node.

Yeah, seems like a good idea. I still prefer to leave the
MPIC_WANTS_RESET for the default case (SMP mode), which I think is
what most people are using.

I'm sending a v2 of the patch, thanks!

-- 
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/