| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1310457809-2731-2-git-send-email-stefanha@linux.vnet.ibm.com> Date: Tue, 12 Jul 2011 09:03:27 +0100 From: Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com> To: Len Brown <lenb@...nel.org>, Anton Vorontsov <cbou@...l.ru>, David Woodhouse <dwmw2@...radead.org> Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com> Subject: [PATCH 1/3] power_supply: scrub device pointer if registration fails This patch makes power_supply_register() safer for callers that are not being careful. When the function fails it leaves the caller's psy.dev pointer set to the stale power supply device. A correct caller would handle the error return and never use psy.dev but the example of drivers/acpi/battery.c shows otherwise. Clear the psy.dev pointer when power_supply_register() fails so the caller either sees a valid pointer on success or NULL on failure. Signed-off-by: Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com> --- drivers/power/power_supply_core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c index 329b46b..33d4068 100644 --- a/drivers/power/power_supply_core.c +++ b/drivers/power/power_supply_core.c @@ -194,6 +194,7 @@ create_triggers_failed: kobject_set_name_failed: device_add_failed: put_device(dev); + psy->dev = NULL; /* make it crystal-clear that we failed */ success: return rc; } -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists