linux-kernel - Re: [PATCH v2] powerpc32: Kexec support for PPC440X chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110713111822.GE4203@zod.rchland.ibm.com>
Date:	Wed, 13 Jul 2011 07:18:22 -0400
From:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To:	Kumar Gala <galak@...nel.crashing.org>
Cc:	"Suzuki K. Poulose" <suzuki@...ibm.com>,
	Benjammin Herrenschmidt <benh@...nel.crashing.org>,
	linux ppc dev <linuxppc-dev@...ts.ozlabs.org>,
	kexec <kexec@...ts.infradead.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	lkml <linux-kernel@...r.kernel.org>,
	Vivek Goyal <vgoyal@...hat.com>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH v2] powerpc32: Kexec support for PPC440X chipsets

On Wed, Jul 13, 2011 at 12:28:36AM -0500, Kumar Gala wrote:
>
>On Jul 12, 2011, at 1:44 AM, Suzuki K. Poulose wrote:
>
>> Changes from V1: Uses a tmp mapping in the other address space to setup
>> 		 the 1:1 mapping (suggested by Sebastian Andrzej Siewior).
>> 
>> Note: Should we do the same for kernel entry code for PPC44x ?
>> 
>> This patch adds kexec support for PPC440 based chipsets.This work is based
>> on the KEXEC patches for FSL BookE.
>> 
>> The FSL BookE patch and the code flow could be found at the link below:
>> 
>> 	http://patchwork.ozlabs.org/patch/49359/
>> 
>> Steps:
>> 
>> 1) Invalidate all the TLB entries except the one this code is run from
>> 2) Create a tmp mapping for our code in the other address space and jump to it
>> 3) Invalidate the entry we used
>> 4) Create a 1:1 mapping for 0-2GiB in blocks of 256M
>> 5) Jump to the new 1:1 mapping and invalidate the tmp mapping
>> 
>> I have tested this patches on Ebony, Sequoia boards and Virtex on QEMU.
>> It would be great if somebody could test this on the other boards.
>> 
>> Signed-off-by: 	Suzuki Poulose <suzuki@...ibm.com>
>> Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>> ---
>> 
>> arch/powerpc/Kconfig             |    2 
>> arch/powerpc/include/asm/kexec.h |    2 
>> arch/powerpc/kernel/misc_32.S    |  170 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 172 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 423145a6..d04fae0 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -349,7 +349,7 @@ config ARCH_ENABLE_MEMORY_HOTREMOVE
>> 
>> config KEXEC
>> 	bool "kexec system call (EXPERIMENTAL)"
>> -	depends on (PPC_BOOK3S || FSL_BOOKE) && EXPERIMENTAL
>> +	depends on (PPC_BOOK3S || FSL_BOOKE || (44x && !SMP && !47x)) && EXPERIMENTAL
>
>Is there something special about 47x that its not supported?

It's a different MMU type (again), that is similar to 44x but not exact.
We can't run a single kernel image on both yet, for example.

Also, they aren't widely available so testing on them is difficult.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/