linux-kernel - Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110713114943.GD25895@sepie.suse.cz>
Date:	Wed, 13 Jul 2011 13:49:43 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Arnaud Lacombe <lacombar@...il.com>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nir Tzachar <nir.tzachar@...il.com>,
	Andrej Gelenberg <andrej.gelenberg@....edu>
Subject: Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu

On Sun, Jul 10, 2011 at 03:27:05AM -0400, Arnaud Lacombe wrote:
> nconf does not check the validity of the current menu when help is requested
> (with either <F2>, '?' or 'h'). This leads to a NULL pointer dereference when an
> empty menu is encountered.
> 
> The following reduced testcase exposes the problem:
> 
> config DEP
>         bool
> 
> menu "FOO"
> 
> config BAR
>         bool "BAR"
>         depends on DEP
> 
> endmenu
> 
> Issue will happen when entering menu "FOO" and requesting help.
> 
> nconf is the only front-end which do not filter the validity of the current
> menu. Such filter can not really happen beforehand as other key which does not
> deals with the current menu might be entered by the user, so just bails out
> earlier if we encounter an invalid menu.
> 
> Cc: Nir Tzachar <nir.tzachar@...il.com>
> Cc: Andrej Gelenberg <andrej.gelenberg@....edu>
> Reported-by: Andrej Gelenberg <andrej.gelenberg@....edu>
> Signed-off-by: Arnaud Lacombe <lacombar@...il.com>

Thanks, applied both patches to kbuild-2.6.git#kconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/